Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influxdb pooling: add ability to pool db writes #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

schulzad
Copy link

  • fix for influxDB write error. 'null' is not a valid number for value= field
  • Enabled by default. This handles only the softPolling() events.
  • Misc cleanup and handle possibility of a null uptime

@schulzad
Copy link
Author

look like #20 might also fix the null value error.
I can rebase off that if need be.

refactor parsing code out into it's own function. in the softpoll build
all the data that will be sent to influxdb and post it all at once.
fix for influxDB write error. 'null' is not a valid number for value= field
@schulzad
Copy link
Author

schulzad commented Feb 9, 2018

Is this being maintained anymore? If not, can you add me to this repo or fork the influxdb stuff to another repo so we can get some of these changes in?

@posborne
Copy link

posborne commented Nov 5, 2018

@codersaur I'm one of the SmartThings developers (as is @schulzad). Several of the core team use this integration and really enjoy it. This patch is fairly important for correct operations with a large number of devices as otherwise the softPoll generates an HubAction for each configured device. If a large number of things are configured, this results in dropped requests as the cloud has a max queue depth for LAN messages to the hub.

These errors are not exposed directly to users as the queue depth restriction is handled by a different edge service managing the connections with the hub but you can see a pretty clear 5 minute spike of errors for my home setup due to the softPoll capping out the LAN queue. This can also affect other LAN automations that may be doing something more important than syncing data to influx.

This PR collapses down all of the requests that would happen on softPoll down to a single HTTP request which keeps this from being a problem. Please let us know if you have any questions.

image

tteggelit added a commit to tteggelit/SmartThingsInfluxDB that referenced this pull request Nov 25, 2018
freddyrayes added a commit to freddyrayes/SmartThings-InfluxDB that referenced this pull request Jul 11, 2019
influxdb pooling: add ability to pool db writes
codersaur#27
@SmartCarrion
Copy link

Did you guys think about creating an active fork or something? Seems abandoned here.

@schulzad
Copy link
Author

Did you guys think about creating an active fork or something? Seems abandoned here.

Unfortunately the way the licensing is setup, this cannot be forked and maintained. At least not officially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants