Fixed LLtoUTMUPSObject northing values in southern hemisphere. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isInUPSSpace library convenience method.
samuelechu
approved these changes
Jan 4, 2019
…o add unit test cases to isInUPSSpace test.
Variadicism-zz
approved these changes
Jan 4, 2019
|
Hero successful 🍾 |
|
USNG4J equivalent PR: codice/usng4j#15 |
dimitry-sherman
approved these changes
Jan 9, 2019
Lambeaux
reviewed
Jan 9, 2019
Lambeaux
approved these changes
Jan 9, 2019
andrewkfiedler
approved these changes
Jan 9, 2019
andrewkfiedler
approved these changes
Jan 9, 2019
| } else { | ||
| let utmcoords = [0, 0, 0, 'N'] | ||
| this.LLtoUTMwithNS(lat, lon, utmcoords) | ||
| return { |
There was a problem hiding this comment.
This confused me a bit at first because I didn't realize utmcoords would be mutated by LLtoUTMwithNS.
Probably my own preference here, but I would prefer to avoid the mutation and have LLtoUTMwithNS return something instead.
That's outside this change though.
| @@ -638,15 +638,27 @@ extend(Converter.prototype, { | |||
| } | |||
| }, | |||
|
|
|||
| isInUPSSpace(lat) { | |||
There was a problem hiding this comment.
Since this is a typescript file we could define the type for this function to catch possible issues at compile time.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Northing values in the southern hemisphere are now correctly converted from Lat Lon to UTM. The unit tests have been updated to check northing values. In addition a isInUPSSpace convenience method is added with unit tests to help library users verify if a Lat Lon coordinate can be converted to UPS or not.