Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate 'capture_only_intended' flag for silent execution in … #832

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: Integrate 'capture_only_intended' flag for silent execution in … #832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/bot/core/core.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,10 @@ class CoreClass {
const { answer } = ctxMessage
logger.log(`[sendProviderAndSave]: `, ctxMessage)
if (answer && answer.length && answer !== '__call_action__') {
await this.providerClass.sendMessage(numberOrId, answer, ctxMessage)
logger.log(`[providerClass.sendMessage]: `, ctxMessage)
if (answer !== '__capture_only_intended__') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

para evitar typos por parte de los usuarios es más prudencial usar una key al estilo ONLYCAPTURE en lugar de una larga y con muchas subrayas "_" y algunas de ellas dobles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tienes razón, de hecho comenté que la funcionalidad de utilizar 'capture' en 'addAnswer' sin enviar un mensaje al usuario, podría ser más conveniente implementarlo mediante el envío de 'null' en lugar de una cadena. Otra opción sería que 'addAction' admita 'capture' directamente... aunque el doble underscore es intensional para que quien lo use tenga que escribir algo largo y sin typos.

await this.providerClass.sendMessage(numberOrId, answer, ctxMessage)
logger.log(`[providerClass.sendMessage]: `, ctxMessage)
}
await this.databaseClass.save({ ...ctxMessage, from: numberOrId })
logger.log(`[databaseClass.save]: `, ctxMessage)
}
Expand Down