Fix logic. De Morgan's law says: not (A or B) = not A and not B #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in my comment to video #32 of 38, Basic User Permissions, the logic for throwing the 404 pages is flawed. As is, users with only one attribute (just superuser, or just staff) will get the 404.
Negating the or-clauses means you have to either put them in parentheses, or replace the "or" with an "and" as per De Morgan's laws.
After this patch has been applied staff users don't have to be superusers anymore for the logic to work, which (I assume) was the intention all along.