Catch up with upstream. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only apply it when necessary - code cleanup - threw out the old "we center it ourselves so it doesn't blur to hell"-workaround - doesn't seem necessary anymore
null shouldn't be passed here.
It causes issues with the positioning of outlines / shadows. Also, the inserted spaces can be quite noticable...
closes #1600
The terms are used pretty interchangeably, but let's be consistent with what the GitHub description says. [skip ci]
[skip ci]
[skip ci]
[skip ci]
Makes sense in a way, since it's only used for the Readme on GitHub.. Less clutter in the root directory. [skip ci]
The text position is slightly different on Flash and Native, so hardcoding the pixel x / y was problematic.
Default true so as to not break existing code.
Has some issues with assets being included.
This is a better fix for the old blurry lines bug on flash.
(non-numeric values)
[skip ci]
- the import warnings only appear with checkstyle dev because of some fixed crashes - workaround for crash in FlxGame#updateInput() (see HaxeCheckstyle/haxe-checkstyle#238) - added TestSuite to excludes again
…lled by another method in setRange()
…ge getter (when min value isn't 0).
Seems like TextField#length was implemented only recently on legacy. Closes #1819
* The top and left edges of checked objects were not registering as overlapping, when they should be. (Consider the example of a single pixel at 0,0: the former could would never register an overlap with the mouse, always looking for your position to be > 0 and < 1. Even though it's a float, it still gets updated to integer values when you move the mouse.) May seem trivial, but when you have a button at the edge of a full-screen game, it becomes important. * Fix test by moving button out from under the cursor. * Add unit test for #1818. Also make the existing unit test remove from the state afterwards so we don't double-add, while leaving the existing tests independent of having been add()ed.
- fixed graph line starting from upper left / (0, 0) - fixed graph being drawn on top of x axis (one pixel above now) - fixed x axis not showing on native targets
Also don't build FlxNape on cpp to reduce build times and avoid termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.