Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make submit consent more clear #399

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Make submit consent more clear #399

merged 8 commits into from
Oct 22, 2024
+734 −282

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 21, 2024 •
edited
Loading

Fixes #394

image

image

@MrOrz MrOrz marked this pull request as draft October 21, 2024 08:00
@MrOrz MrOrz self-assigned this Oct 21, 2024
@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11438419328

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.632%
Totals Coverage Status
Change from base Build 11435720582: 0.1%
Covered Lines: 1079
Relevant Lines: 1150
💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review October 21, 2024 10:42
@nonumpa
Copy link
Member

nonumpa commented Oct 21, 2024

I noticed different reply types in the screenshots. Do we need to update createAskArticleSubmissionConsentReply to quickReply as well? (maybe in another pr)

@MrOrz
Copy link
Member Author

MrOrz commented Oct 22, 2024

I noticed different reply types in the screenshots. Do we need to update createAskArticleSubmissionConsentReply to quickReply as well? (maybe in another pr)

I remember that quick replies don't show on Desktop LINE app. Also, Desktop LINE app can only share 1 message at a time.
This is why I keep buttons in single message report flow.

If multiple message & quick reply is supported on Desktop LINE app, we can consider switching to quick replies as well.

@MrOrz MrOrz merged commit ff44a10 into master Oct 22, 2024
4 checks passed
@MrOrz MrOrz deleted the submit-consent branch October 22, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@andyy0216 andyy0216 andyy0216 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust user submission consent wording
5 participants
@MrOrz @coveralls @nonumpa @andyy0216 @bil4444