Handling integers in request params

[jdhollis]

From the (aws/ops) output, I expected :FromPort and :ToPort to require a number, but I got a casting error: “java.lang.Long cannot be cast to java.lang.String”.

(select-keys (get-in (aws/ops @ec2-client) 
                     [:AuthorizeSecurityGroupIngress :request])
             [:FromPort :ToPort])

{:FromPort integer, :ToPort integer}

(aws/invoke @ec2-client {:op :AuthorizeSecurityGroupIngress
                         :request {:CidrIp cidr-ip
                                   :FromPort 22
                                   :GroupId security-group-id
                                   :IpProtocol "tcp"
                                   :ToPort 22}})

Passing in strings works fine:

(aws/invoke @ec2-client {:op :AuthorizeSecurityGroupIngress
                         :request {:CidrIp cidr-ip
                                   :FromPort "22"
                                   :GroupId security-group-id
                                   :IpProtocol "tcp"
                                   :ToPort "22"}})

I’m using the following versions:

[com.cognitect.aws/api "0.8.149"]
[com.cognitect.aws/endpoints "1.1.11.462"]
[com.cognitect.aws/ec2 "681.2.373.0"]
[com.cognitect.aws/ecs "668.2.364.0"]

Should we always pass in strings as request parameters?

[jdhollis]

Found a counterexample in the ECS client:

(aws/invoke @ecs-client {:op :RunTask
                         :request {:cluster cluster-name
                                   :taskDefinition task-family
                                   :count 1
                                   … }})

If I pass "1" into :count, I get "class java.lang.String can not be converted to an Integer".

[dchelimsky]

Yes, the counter example behaves as expected because it expects an int. The bug is that we're trying to url-encode the number, assuming it's a string. Fix coming soon.

[dchelimsky]

Released in 0.8.155.