-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump rust toolchain for rustc 1.82 in rustc_plugin 🚧 #30
feat: Bump rust toolchain for rustc 1.82 in rustc_plugin 🚧 #30
Conversation
Having issues after bumping this in
Not sure if this is due to the changes here |
Adding |
Yeah unfortunately every compiler version update tends to break something in our extended tool ecosystem. Is there a reason you need latest rustc? |
I need rust 1.82 because I am running codegen on this crate https://github.com/bevyengine/bevy/blob/61d4048acb45572f5dd3a9f9245042be1a91e526/Cargo.toml#L13 which is its MSRV |
The modifications here work fine in the linked PR, I've had to add rustc_private features to my binaries as I said above (I can't remember if that's a big deal or not), but other than that it's fine |
Fixed in #32. |
I was going to update
rustc_utils
too butMirPass
is no longer public (not sure if on purpose) rust-lang/rust#129926