Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow badges show "main.yml" but should say tests. #16

Closed
jaraco opened this issue Aug 25, 2024 · 3 comments
Closed

Workflow badges show "main.yml" but should say tests. #16

jaraco opened this issue Aug 25, 2024 · 3 comments

Comments

@jaraco
Copy link
Member

jaraco commented Aug 25, 2024

Taking a look at the projects, there's a variance between the coherent and skeleton projects:

image

Coherent badges show "main.yml". It would be more descriptive for it to display "tests". Let's figure out why it's different and see if we can't get "tests" in there.

@bswck
Copy link
Member

bswck commented Aug 25, 2024

I think it's different because names in the badges are determined from the front-end workflows' name property that defaults to the workflow filename. So... yet another boilerplate to add & maintain :/

@bswck
Copy link
Member

bswck commented Aug 25, 2024

It would be pretty cool to somehow smuggle the name from the reusable workflow using a dynamic expression.

@bswck
Copy link
Member

bswck commented Aug 25, 2024

I've experimented a little, and it's impossible to have a dynamic name.
run-name won't influence the name displayed in the badge.

We need to populate some boilerplate.

bswck added a commit to coherent-oss/coherent.build that referenced this issue Aug 25, 2024
bswck added a commit to coherent-oss/coherent.test that referenced this issue Aug 25, 2024
bswck added a commit to coherent-oss/coherent.cli that referenced this issue Aug 25, 2024
@bswck bswck closed this as completed Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants