Add more command flags #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/check_construction.go
Outdated
| @@ -76,6 +77,7 @@ func runCheckConstructionCmd(_ *cobra.Command, _ []string) error { | |||
| fetcherOpts = append(fetcherOpts, fetcher.WithForceRetry()) | |||
| } | |||
|
|
|||
| log.Println("node url: ", Config.OnlineURL) | |||
cmd/root.go
Outdated
| @@ -48,6 +48,8 @@ var ( | |||
| cpuProfile string | |||
| memProfile string | |||
| blockProfile string | |||
| onlineUrl string | |||
| // Override start and end syncing index in configuration file when it's explicitly set via CLI | ||
| if startIndex != -1 { | ||
| Config.Data.StartIndex = &startIndex | ||
| Config.Data.InitialBalanceFetchDisabled = false |
There was a problem hiding this comment.
Please add comments why we toggle the flag.
irisZhangCB
force-pushed
the
pass-in-node-url
branch
from
36523f8 to
342cb05
Compare
xiaying-peng
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Added node-url flag to
check:dataandcheck:construction, so that node url can be set via CLI, overriding the value in configuration file.Added start and end index as flags to
check:dataas well.Solution
Open questions