feat: throw one type error for json parse strict = true (#74)

Co-authored-by: dmytro.fedotov <[email protected]>
cojs · Aug 12, 2020 · 960986e · 960986e
1 parent a847bfd
commit 960986e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/json.js b/lib/json.js
@@ -52,7 +52,7 @@ module.exports = async function(req, opts) {
     if (!str) return {};
     // strict JSON test
     if (!strictJSONReg.test(str)) {
-      throw new Error('invalid JSON, only supports object and array');
+      throw new SyntaxError('invalid JSON, only supports object and array');
     }
     return JSON.parse(str);
   }

diff --git a/test/json.test.js b/test/json.test.js
@@ -83,6 +83,7 @@ describe('parse.json(req, opts)', function() {
         try {
           yield parse.json(this);
         } catch (err) {
+          err.should.be.an.instanceOf(SyntaxError);
           err.status.should.equal(400);
           err.body.should.equal('{"foo": "bar');
           done();
@@ -124,6 +125,7 @@ describe('parse.json(req, opts)', function() {
           try {
             yield parse.json(this, { strict: true });
           } catch (err) {
+            err.should.be.an.instanceOf(SyntaxError);
             err.status.should.equal(400);
             err.body.should.equal('"foo"');
             err.message.should.equal('invalid JSON, only supports object and array');