recordWithBrandedKeys should not be partial

colinhacks · Dec 19, 2024 · fb936ed · fb936ed
1 parent f7ad261
commit fb936ed
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/deno/lib/__tests__/record.test.ts b/deno/lib/__tests__/record.test.ts
@@ -17,6 +17,9 @@ const recordWithLiteralKeys = z.record(
 );
 type recordWithLiteralKeys = z.infer<typeof recordWithLiteralKeys>;
 
+const recordWithBrandedKeys = z.record(z.string().brand("someKey"), z.string());
+type recordWithBrandedKeys = z.infer<typeof recordWithBrandedKeys>;
+
 test("type inference", () => {
   util.assertEqual<booleanRecord, Record<string, boolean>>(true);
 
@@ -29,6 +32,11 @@ test("type inference", () => {
     recordWithLiteralKeys,
     Partial<Record<"Tuna" | "Salmon", string>>
   >(true);
+
+  util.assertEqual<
+    recordWithBrandedKeys,
+    Record<string & z.BRAND<"someKey">, string>
+  >(true);
 });
 
 test("methods", () => {

diff --git a/deno/lib/types.ts b/deno/lib/types.ts
@@ -3691,7 +3691,7 @@ export type RecordType<K extends string | number | symbol, V> = [
   ? Record<K, V>
   : [symbol] extends [K]
   ? Record<K, V>
-  : [BRAND<string | number | symbol>] extends [K]
+  : [K] extends [BRAND<string | number | symbol>]
   ? Record<K, V>
   : Partial<Record<K, V>>;
 export class ZodRecord<

diff --git a/src/__tests__/record.test.ts b/src/__tests__/record.test.ts
@@ -16,6 +16,9 @@ const recordWithLiteralKeys = z.record(
 );
 type recordWithLiteralKeys = z.infer<typeof recordWithLiteralKeys>;
 
+const recordWithBrandedKeys = z.record(z.string().brand("someKey"), z.string());
+type recordWithBrandedKeys = z.infer<typeof recordWithBrandedKeys>;
+
 test("type inference", () => {
   util.assertEqual<booleanRecord, Record<string, boolean>>(true);
 
@@ -28,6 +31,11 @@ test("type inference", () => {
     recordWithLiteralKeys,
     Partial<Record<"Tuna" | "Salmon", string>>
   >(true);
+
+  util.assertEqual<
+    recordWithBrandedKeys,
+    Record<string & z.BRAND<"someKey">, string>
+  >(true);
 });
 
 test("methods", () => {

diff --git a/src/types.ts b/src/types.ts
@@ -3691,7 +3691,7 @@ export type RecordType<K extends string | number | symbol, V> = [
   ? Record<K, V>
   : [symbol] extends [K]
   ? Record<K, V>
-  : [BRAND<string | number | symbol>] extends [K]
+  : [K] extends [BRAND<string | number | symbol>]
   ? Record<K, V>
   : Partial<Record<K, V>>;
 export class ZodRecord<