-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOJIRA : add a 3rd attempt for failsafe video thumb extraction #1650
Open
gautiermichelin
wants to merge
406
commits into
collectiveaccess:master
Choose a base branch
from
gautiermichelin:patch-6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NOJIRA : add a 3rd attempt for failsafe video thumb extraction #1650
gautiermichelin
wants to merge
406
commits into
collectiveaccess:master
from
gautiermichelin:patch-6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type_name_* prematurely set for listing sets by user
Localize Maximum upload size
Localize select options for display settings
Quick fix for Set list by user headings
…ighlight-user-headings-to-help-read-the-listing Set list by user: highlight user headings to help read the listing
using brackets doesn't work for PHP 8, throws deprecation warning in PHP 7.4
Time parser cs
use [] instead of {} for getting character
Bring bracket back into its commented-out block
Localize the default text in required_field_marker, for instances where show_required_field_marker is set to 1. The text to be translated would not be picked up if maintained verbatim (that is, _t((Required)) would not be localized at runtime for some reason tied to the use of parenthesis). Not knowing the escape rules (if any), I've cowardly moved the string to square brackets, with _t([Required]) working as expected. Installs using the default string will notice a change from (Required) to [Required]. Hope it helps anyway.
Localize required_field_marker
Update docx_results.php : missing field names in the docx export
Update docx_results.php : missing field names in the docx export
Removed duplicate relationship types from dacs_heritage.xml
added several new Nomisma classes for information service, refining c…
…rst level of places Replacing : ca_places_locations_hierarchy_browser_hide_root By : ca_places_hierarchy_browser_hide_root
Change ca_places_locations_hierarchy_browser_hide_root to hide the fi…
Corrected display format for Creator column
Remove "null" date type
Fixing typo in global resourcespace information service settings variable.
Update ResourceSpace.php
…ToCorrectDocumentationOnProfiles Correct the installer link to documentation about profiles
Corrected a typo in dacs_heritage.xml
Enabled client-side caching in the IIIF service.
Update app.conf : logo for reports, svg is not valid for a docx export
Update app.conf : logo for reports, svg is not valid for a docx export
Fix: consistently translate "lot" to "Konvolut" or "Objektstapel" in German
NOJIRA : - correction of the 2nd : "// try again, with -ss 1" => the -ss 1 wasn't applied - add a 3rd failsafe video thumb extraction, without the "pad" indication inside the -vf, this secured me many cases where 1st and 2nd attempts gave nothing
What version(s) of ffmpeg is this tested with? |
ffmpeg version 4.3.8-0+deb11u1 ; debian 11.11 |
bump ? |
This is against 1.7. Is that what you want? |
0333644
to
0881dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOJIRA :