Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad line detection when swap start monero_wallet_rpc #353

Closed
devbordecraft opened this issue Mar 19, 2021 · 2 comments · Fixed by #379
Closed

Bad line detection when swap start monero_wallet_rpc #353

devbordecraft opened this issue Mar 19, 2021 · 2 comments · Fixed by #379
Assignees
@rishflab
Labels
cli Related to the swap CLI tool

Comments

@devbordecraft
Copy link

The line detection to detect if monero_wallet_rpc has been started in source swap/src/monero/wallet_rpc.rs:150 can be translated in many different language. So the line detection can't work if the local settings on the computer is configured to be other than english like in french for example.
@thomaseizinger thomaseizinger added the cli Related to the swap CLI tool label Mar 23, 2021
@rishflab rishflab self-assigned this Mar 23, 2021
rishflab added a commit that referenced this issue Mar 25, 2021
@rishflab
Use language agnostic heuristic to check if monero_wallet_rpc is ready
c25d0ff 
Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.

Closes #353.
@rishflab rishflab mentioned this issue Mar 25, 2021
Merged
rishflab added a commit that referenced this issue Mar 25, 2021
@rishflab
Use language agnostic heuristic to check if monero_wallet_rpc is ready
1ac3569 
Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.

Closes #353.
rishflab added a commit that referenced this issue Mar 25, 2021
@rishflab
Use language agnostic heuristic to check if monero_wallet_rpc is ready
29cb192 
Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.

Closes #353.
rishflab added a commit that referenced this issue Mar 25, 2021
@rishflab
Use language agnostic heuristic to check if monero_wallet_rpc is ready
f70e3cc 
Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.

Closes #353.
@rishflab
Copy link
Member

rishflab commented Mar 25, 2021 •
edited
Loading

@devbordecraft what operating system are you on?

@devbordecraft
Copy link
Author

I am using Ubuntu 20.04 with only the French language pack installed.

bors bot added a commit that referenced this issue Mar 26, 2021
@bors @rishflab
Merge #379
1684f4b 
379: Use language agnostic heuristic to check if monero_wallet_rpc is ready r=rishflab a=rishflab

Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.

Closes #353.

NOTE: will squash after approved

Co-authored-by: rishflab <[email protected]>
@bors bors bot closed this as completed in bc902ea Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishflab rishflab

Labels
cli Related to the swap CLI tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use language agnostic heuristic to check if monero_wallet_rpc is ready comit-network/xmr-btc-swap
3 participants
@thomaseizinger @rishflab @devbordecraft