Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Support new Initial transaction state #175

Open
3 of 4 tasks
andrii-kovalenko-ct opened this issue Oct 19, 2017 · 0 comments
Open
3 of 4 tasks

Support new Initial transaction state #175

andrii-kovalenko-ct opened this issue Oct 19, 2017 · 0 comments
Assignees
@butenkor
Labels
checked feature in progress jira This issue has an associated Jira task major
Milestone
v2.4.0

Comments

@andrii-kovalenko-ct
Copy link
Contributor

andrii-kovalenko-ct commented Oct 19, 2017 •
edited
Loading

Since version 1.24.0 in addition to Pending now CTP supports Initial state:

http://dev.commercetools.com/release-notes.html#release-notes---commercetools-platform---version-release-29-september-2017

https://dev.commercetools.com/http-api-projects-payments.html#transactionstate

Initial is not default so far, but will be in the future (follow the update notes).

So, the service should be updated with the following requirements:

  • First treat Initial state same as Pending, e.g. execute transaction if state is one of these.
    • Update JVM SDK version
    • Update transaction execution/notification handling so they set explicitly Pending when transaction is accepted by payment provider
  • When the platform switches to Initial as default state - update the service to treat only Initial as a new transaction, an Pending as already sent one.

Linked issue in commercetools-payment-integration-java: commercetools/commercetools-payment-integration-java#56
@andrii-kovalenko-ct andrii-kovalenko-ct self-assigned this Oct 19, 2017
@andrii-kovalenko-ct andrii-kovalenko-ct mentioned this issue Oct 19, 2017
Open
1 task
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: update JVM SDK to v1.24.0
ce45f04
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix MonetaryUtil deprecation
ca19a45
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: update build version to 2.1.0-dev
3b935b1
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: remove deprecated SetAuthorization and SetAmountPaid update act…
acd708f 
…ions
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: update gradle script:
6fdf295 
  - replace deprecated "compile" and "testCompile" dependencies
  - use the latest AssertJ
  - update Moneta to 1.1
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: exclude Moneta from the dependencies (use transitive from CTP SDK)
b61d230
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix PaidNotificationProcessorTest: exclude SetAmountPaid assertion
fb3a573
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix AppointedNotificationProcessorTest: exclude SetAuthorizatio…
ef4a4f3 
…n assertion
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix CreditCardRequestFactoryTest: remove deprecated getAmountAu…
16e4547 
…thorized
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix wrong minor monetary extraction: use convertMinorPart()
3ef010f
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: TenantFactoryTest: mock sphere client config
7dab25f
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix MoneyUtil and test mocks
dc42546
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix Klarna test mocks
9b5c566
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix functional test dependencies
33c2a3c
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix functional test dependencies
82d14e2
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: functionaltests: PaymentService - don't verify amount paid
40bf049
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: functionaltests: PaymentFixture: skip amountAuthorized and amou…
0482dd7 
…ntPaid verification
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: functionaltests: PaymentFixture: skip amountAuthorized and amou…
9e625d0 
…ntPaid verification
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: functionaltests: remove deprecated amounts from the test mocks
aa22197
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: update migration guide
38ff13c
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: fix AddLineItem.of deprecation usage
f1541d1
andrii-kovalenko-ct added a commit that referenced this issue Oct 19, 2017
@andrii-kovalenko-ct
#175: update shadow plugin
c1ec785
andrii-kovalenko-ct added a commit that referenced this issue Jan 23, 2018
@andrii-kovalenko-ct
#175: minor class renaming to convention
86b7a76
andrii-kovalenko-ct added a commit that referenced this issue Jan 23, 2018
@andrii-kovalenko-ct
#175: re-factor redirect url generating for functional tests
1667956
andrii-kovalenko-ct added a commit that referenced this issue Jan 23, 2018
@andrii-kovalenko-ct
#175: fix test cases after redirect url re-factoring
2d77f31
andrii-kovalenko-ct added a commit that referenced this issue Jan 23, 2018
@andrii-kovalenko-ct
#175: rename wrong argument name (service -> tenant)
8da39a2
@andrii-kovalenko-ct andrii-kovalenko-ct mentioned this issue Jan 23, 2018
Merged
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: update migration guide
3f26538
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: update Field Mapping about Initial transaction state
adbe760
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: remove obsolete comments
4c280c3
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: simplify if expression in wasExecuted
516507c
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: improve methods annotations
8d9f164
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: improve doc
342d6e8
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: improve doc
09ab037
andrii-kovalenko-ct added a commit that referenced this issue Jan 25, 2018
@andrii-kovalenko-ct
#175: fix doc
ef445a6
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: rename variable
4d6a5cc
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: update comment and doc
e227407
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: re-factor transactions update actions creation
2eed23f
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: add @NonNul annotations
f5b54a9
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: add some nonnulls
11330c9
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: remove *List suffixes
557ad2f
andrii-kovalenko-ct added a commit that referenced this issue Jan 26, 2018
@andrii-kovalenko-ct
#175: minor formatting
dbf0c71
@heshamMassoud heshamMassoud mentioned this issue Jan 14, 2020
Merged
@ahalberkamp ahalberkamp mentioned this issue Aug 18, 2020
Closed
@JudeNiroshan JudeNiroshan added the jira This issue has an associated Jira task label Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@butenkor butenkor

Labels
checked feature in progress jira This issue has an associated Jira task major
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
5 participants
@butenkor @ahalberkamp @JudeNiroshan @andrii-kovalenko-ct @praveenkumarct