Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow language specific preprocessors to reject sentences #17

Closed
kdavis-mozilla opened this issue Dec 13, 2018 · 0 comments
Closed

Allow language specific preprocessors to reject sentences #17

kdavis-mozilla opened this issue Dec 13, 2018 · 0 comments
Assignees
@kdavis-mozilla

Comments

@kdavis-mozilla
Copy link
Contributor

In some cases the sentence a preprocessor is presented with is, after preprocessing, empty or obviously incorrect. For example, in the English data set there are validated sentences of the form

"<html lang=""en"">"

which obviously is the result of some bug or bugs in the Common Voice code.

Upon preprocessing such a sentence would be empty or obviously incorrect and should not be included in any validated data set.

The result of this issue should be some means of allowing preprocessors to reject sentences and move them from the valid data set to the invalid data set.
@kdavis-mozilla kdavis-mozilla changed the title Allow preprocessors to reject sentences Allow language specific preprocessors to reject sentences Dec 13, 2018
kdavis-mozilla added a commit that referenced this issue Dec 14, 2018
@kdavis-mozilla
Merge pull request #22 from mozilla/issue17
2b80f8c 
Fixed #17 (Allow language specific preprocessors to reject sentences)
@kdavis-mozilla kdavis-mozilla self-assigned this Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdavis-mozilla kdavis-mozilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdavis-mozilla