Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the common preprocessor to reject sentences #20

Closed
kdavis-mozilla opened this issue Dec 13, 2018 · 0 comments
Closed

Allow the common preprocessor to reject sentences #20

kdavis-mozilla opened this issue Dec 13, 2018 · 0 comments
Assignees
@kdavis-mozilla

Comments

@kdavis-mozilla
Copy link
Contributor

In some cases the sentence the "common" preprocessor is presented with is, after preprocessing, empty or obviously incorrect. For example, in the English data set there are sentences of the form

"<html lang=""en"">"

which obviously are the result of some bug or bugs in the Common Voice code.

Upon preprocessing, such a sentence would be empty or obviously incorrect and should not be included in the "valid" or "other" data sets.

The result of this issue should be some means of allowing the "common" preprocessor to reject sentences and move them to an "invalid" data set.
@kdavis-mozilla kdavis-mozilla self-assigned this Dec 13, 2018
kdavis-mozilla added a commit that referenced this issue Dec 14, 2018
@kdavis-mozilla
Merge pull request #21 from mozilla/issue20
89f523f 
Fixed #20 (Allow the common preprocessor to reject sentences)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdavis-mozilla kdavis-mozilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdavis-mozilla