Readme and logging #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavis-mozilla
suggested changes
Dec 19, 2018
src/corporacreator/corpora.py
Outdated
| _logger = logging.getLogger(__name__) | ||
| _logger.setLevel(logging.DEBUG) |
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
src/corporacreator/corpora.py
Outdated
| _logger = logging.getLogger(__name__) | ||
| _logger.setLevel(logging.DEBUG) | ||
| _logger.addHandler(logging.FileHandler('corpora.log')) |
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
src/corporacreator/corpus.py
Outdated
| _logger = logging.getLogger(__name__) | ||
| _logger.setLevel(logging.DEBUG) |
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
src/corporacreator/corpus.py
Outdated
| _logger = logging.getLogger(__name__) | ||
| _logger.setLevel(logging.DEBUG) | ||
| _logger.addHandler(logging.FileHandler('corpus.log')) |
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
src/corporacreator/tool.py
Outdated
| @@ -7,7 +7,8 @@ | |||
|
|
|||
|
|
|||
| _logger = logging.getLogger(__name__) | |||
|
|
|||
| _logger.setLevel(logging.DEBUG) | |||
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
src/corporacreator/tool.py
Outdated
| @@ -7,7 +7,8 @@ | |||
|
|
|||
|
|
|||
| _logger = logging.getLogger(__name__) | |||
|
|
|||
| _logger.setLevel(logging.DEBUG) | |||
| _logger.addHandler(logging.FileHandler('tool.log')) | |||
There was a problem hiding this comment.
Command line option -vv already allows for debug logging. This is not needed.
|
For example... (.virtualenv) kdavis-19htdh:CorporaCreator kdavis$ create-corpora --help
usage: create-corpora [-h] [--version] [-v] [-vv] -f TSV_FILENAME -d DIRECTORY
[-s DUPLICATE_SENTENCE_COUNT]
Creates tsv files for Common Voice corpora
optional arguments:
-h, --help show this help message and exit
--version show program's version number and exit
-v, --verbose set loglevel to INFO
-vv, --very-verbose set loglevel to DEBUG
-f TSV_FILENAME, --file TSV_FILENAME
Path to the Common Voice tsv for all languages
-d DIRECTORY, --directory DIRECTORY
Directory in which to save the Common Voice corpora
-s DUPLICATE_SENTENCE_COUNT, --duplicate-sentence-count DUPLICATE_SENTENCE_COUNT
Maximum number of times a sentence can appear in a
corpus. |
Fixed #31 (et preprocessor contains invalid python)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to README (python must be python3, and
CorporaCreator kdavis$is a little confusing with the whitespace).Also, added to the
loggerto be more verbose at the terminal and print to log files.