Added flag for running *only* one 1 or more languages #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually no reviewer, but LGTM 👍 |
kdavis-mozilla
suggested changes
Jan 24, 2019
| else: | ||
| locales = corpora_data.locale.unique() | ||
|
|
||
| for locale in locales: |
There was a problem hiding this comment.
You should check that self.args.langs is a subset of corpora_data.locale.unique() and print an error message if it's not and also stop the program.
There was a problem hiding this comment.
@kdavis-mozilla -- requested changes made to README and catch if entered languages are actually subset of possible languages...
also learned that Python has a x.issubset(y) function:)
… documentation to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.