Welsh preprocessing + one change to common.py #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JRMeyer
commented
Jan 29, 2019
JRMeyer
commented
- added a whitespace collapsing line in common.py, which will replace all whitespace(s) with a single space. This should also capture tabs and non-standard whitespaces.
- added to welsh pre-processor, to check for normal letters
|
@kdavis-mozilla -- there's going to be a whole slew of languages coming your way, and the logic in the pre-processing is the same for each. I found (thanks to Francesco from Localization) the CLDR github, which contains alphabets for lots of languages: https://github.com/unicode-cldr/cldr-misc-full/tree/master/main Right now, the LANG.py scripts are just checking if the given sentence is "purely" the alphabet from CLDR, or if there are other chars. This is a good template for people to get started on their own language, I should think. |
kdavis-mozilla
suggested changes
Jan 29, 2019
Closed
kdavis-mozilla
suggested changes
Jan 31, 2019
kdavis-mozilla
suggested changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.