Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design ready/choropleth #175

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Design ready/choropleth #175

merged 3 commits into from
Jan 9, 2025

Conversation

Arbyhisenaj
Copy link
Member

Description

Built the Choropleth legend
image

It has a lot of shared logic with the map layers so it's consistent (e.g using interpolateBlues)

The loading state could be improved. Having a spinner was glitching the layout so i had to keep it blank. Also, I'm not sure if it's location in the code is the best but overall, it's ready enough to demo.

Motivation and Context

How Can It Be Tested?

How Will This Be Deployed?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@commonknowledge-bot commonknowledge-bot deployed to design-ready/chrorpleth - meep-database PR #175 January 8, 2025 17:23 — with Render Active
@Arbyhisenaj Arbyhisenaj requested a review from janbaykara January 8, 2025 17:23
@Arbyhisenaj Arbyhisenaj changed the title Design ready/chrorpleth Design ready/choropleth Jan 8, 2025
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-backend PR #175 January 8, 2025 17:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-backend PR #175 January 8, 2025 17:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-frontend PR #175 January 8, 2025 17:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-worker PR #175 January 8, 2025 17:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-backend PR #175 January 8, 2025 17:25 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design-ready/chrorpleth - meep-intelligence-hub-frontend PR #175 January 8, 2025 17:25 — with Render Destroyed
Copy link
Member

@janbaykara janbaykara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb, tidy, just the treat. If you can run linting, then you're free to merge.

@janbaykara janbaykara merged commit 6fdb12c into main Jan 9, 2025
3 of 4 checks passed
@janbaykara janbaykara deleted the design-ready/chrorpleth branch January 9, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants