COMP: Update C++ source files removing code specific to Qt 4 #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesobutler
force-pushed
the
remove-qt-4-code
branch
2 times, most recently
from
1fba466 to
e2f341e
Compare
jcfr
reviewed
Jul 25, 2023
jamesobutler
force-pushed
the
remove-qt-4-code
branch
from
e2f341e to
e306bd9
Compare
This is a follow-up to commontk@b86197b expand-down.png and expand-up.png are being removed as they were only used in ctkCollapsibleGroupBox built with Qt < 4.6
Qt versions prior to 4.7.0 didn't expose QFileDialog::Options in the public API. CTK began to remove Qt4 support in C++ source files in commontk@b86197b.
jcfr
approved these changes
Jul 26, 2023
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to b86197b
I used search terms such as
QT_VERSION <andQT_VERSION >to find version checks beginning with0xto find more cases of Qt4 related logic to drop.