Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-nullable modifier to return type of functions never returning null #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add non-nullable modifier to return type of functions never returning null #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lightbox-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ angular.module('bootstrapLightbox').provider('Lightbox', function () {
* dimensions if they conflict.
* @param {Object} dimensions Contains the properties `windowWidth`,
* `windowHeight`, `imageWidth`, and `imageHeight`.
* @return {Object} May optionally contain the properties `minWidth`,
* @return {!Object} May optionally contain the properties `minWidth`,
* `minHeight`, `maxWidth`, and `maxHeight`.
* @type {Function}
* @name calculateImageDimensionLimits
Expand Down Expand Up @@ -86,7 +86,7 @@ angular.module('bootstrapLightbox').provider('Lightbox', function () {
* are calculated.
* @param {Object} dimensions Contains the properties `windowWidth`,
* `windowHeight`, `imageDisplayWidth`, and `imageDisplayHeight`.
* @return {Object} Must contain the properties `width` and `height`.
* @return {!Object} Must contain the properties `width` and `height`.
* @type {Function}
* @name calculateModalDimensions
* @memberOf bootstrapLightbox.Lightbox
Expand Down Expand Up @@ -123,7 +123,7 @@ angular.module('bootstrapLightbox').provider('Lightbox', function () {

/**
* @param {*} image An element in the array of images.
* @return {Boolean} Whether the provided element is a video.
* @return {boolean} Whether the provided element is a video.
* @type {Function}
* @name isVideo
* @memberOf bootstrapLightbox.Lightbox
Expand Down Expand Up @@ -245,7 +245,7 @@ angular.module('bootstrapLightbox').provider('Lightbox', function () {
* current image.
* @param {Object} modalParams Custom params for the angular UI
* bootstrap modal (in $uibModal.open()).
* @return {Object} The created UI Bootstrap modal instance.
* @return {!Object} The created UI Bootstrap modal instance.
* @type {Function}
* @name openModal
* @memberOf bootstrapLightbox.Lightbox
Expand Down