Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "Who Was Ill?" page and validation #263

Merged
merged 8 commits into from
Aug 4, 2020

Conversation

rhysbarrett
Copy link
Contributor

@rhysbarrett rhysbarrett commented Aug 3, 2020

JIRA link

https://companieshouse.atlassian.net/browse/LFA-1438

Change description

This commit implements the "Who Was Ill?" page, along with validation. See screenshots below.

Accessibility Note: The Conditional Input causes AXE to throw a critical accessibility error. This is a known and accepted issue within the GOV.UK Frontend system.

image
image
image

Work checklist

  • Tests added where applicable
  • UI changes look good on mobile
  • UI changes meet accessibility criteria

Merge instructions

We are committed to keeping commit history clean, consistent and linear. To acheive this commit should be structured as follows:

<type>[optional scope]: <description>

and contain the following structural elements:

  • fix: a commit that patches a bug in your codebase (this correlates with PATCH in semantic versioning),
  • feat: a commit that introduces a new feature to the codebase (this correlates with MINOR in semantic versioning),
  • BREAKING CHANGE: a commit that has a footer BREAKING CHANGE: introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,
  • types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
  • footers other than BREAKING CHANGE: <description> may be provided.

@rhysbarrett rhysbarrett marked this pull request as ready for review August 3, 2020 17:31
@rhysbarrett rhysbarrett merged commit c24b66f into master Aug 4, 2020
@rhysbarrett rhysbarrett deleted the feature/LFA-1438_who_was_ill branch August 4, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants