Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto hide Thumb issue #25 #26

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

racka98
Copy link
Contributor

@racka98 racka98 commented Oct 8, 2024

This adds isDraggingList as a parameter for the LaunchedEffect responsible for hiding the scrollbar. It should have no effect on performance, and it fixes issue #25

Still not sure about the isHover logic for showing the scrollbar as I can't get the scrollbar to show when hovering over the list on the emulator.

@alexstyl
Copy link
Member

alexstyl commented Oct 8, 2024

Thank you for opening this PR. I will have a look asap

as I can't get the scrollbar to show when hovering over the list on the emulator.

You can run the code in your computer (desktop app) but running ./gradlew demo-scrollarea:run. There should also be a configuration available in the project already to try out.

@alexstyl
Copy link
Member

@racka98 did you test your code on desktop?

@racka98
Copy link
Contributor Author

racka98 commented Oct 14, 2024

@alexstyl just tested on desktop. The same issue was still persistent. I have updated the PR with a solution that works on both desktop and android. Moved the code for showing the the scroll bar and hiding it into a single LaunchedEffect.

@alexstyl
Copy link
Member

Thanks for the contribution. It works great :)

Merging this

@alexstyl alexstyl merged commit b5bb679 into composablehorizons:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants