Remove protectNavBars property

[Perfomer]

Hi there!

I need to make my system bars fully transparent. But ModalBottomSheet forces to protectNavBars = true.

I found the issue #12 and tried this approach, but if you make this:

val window = LocalModalWindow.current
LaunchedEffect(Unit) {
    window.navigationBarColor = Color.TRANSPARENT
    window.statusBarColor = Color.TRANSPARENT
    WindowInsetsControllerCompat(window, window.decorView).isAppearanceLightStatusBars = true
    WindowInsetsControllerCompat(window, window.decorView).isAppearanceLightNavigationBars = true
}

then half-transparent system bars background blinks for a moment anyway.

You can see it on a video:

Screen_recording_20241028_202132.mp4

So it would be great to allow to customize protectNavBars value to avoid it.

Pros:

• No need to declare LaunchedEffect especially for ModalBottomSheet, you can setup it once for the whole application.
• No blinking half-transparent systems bar background when opening ModalBottomSheet.

[alexstyl]

This is not an API I want to support as nav bars have nothing to do with bottom sheets. Plus it is something specific for Android and I don't want to polute the API with platform specific properties.

Can you do me a favor and change your PR to remove the protection code from the Modal instead? More specifically, remove the protectNavBars param from Modal and in the android actual remove the code that alters the window.

The protect param was there before LocalModalWindow was introduced and it's super easy to customize now, so it's not really needed anymore.

PS: I am under the assumption that removing them with cause the nav bar to stay as it was before showing the modal, but you would need to test it out.

[alexstyl]

Btw, unrelated to this PR but I noticed that the sheet in your video is not smooth. (does not appear instantly and skips frames)

Not sure if this is the recording or not, but if it is your app, make sure you are not blocking the UI thread. Might even fix your issue

[Perfomer]

I removed protectNavBars property in the first commit: ac3fc96

And turned back recoloring of the navigation bar when ModalBottomSheet opened (as it was before my changes) in 39c3155, because navigation bar icons become white on white background.

[alexstyl]

The Demo is intended for the documentation website. can you reset the change on the demo?

[Perfomer]

Yeah, sure

[alexstyl]

The Demo is intended for the documentation website. can you reset the change on the demo?

[Perfomer]

Done

[Perfomer]

Btw, unrelated to this PR but I noticed that the sheet in your video is not smooth. (does not appear instantly and skips frames)

Not sure if this is the recording or not, but if it is your app, make sure you are not blocking the UI thread. Might even fix your issue

It's okay, just lagging emulator

[alexstyl]

Looks great. Thanks a lot for the contribution. Merged

[alexstyl]

Available in 1.19.1 https://github.com/composablehorizons/compose-unstyled/releases/tag/1.19.1