make External a boolean #480
Merged
+38
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Nov 20, 2023
| } | ||
| return []byte(fmt.Sprintf(`{"name": %q}`, e.Name)), nil | ||
| } | ||
| type External bool |
There was a problem hiding this comment.
Should we get rid of this type def entirely?
There was a problem hiding this comment.
conversion is implicit as shown on https://github.com/compose-spec/compose-go/pull/480/files#diff-e03e88bd30c556736d10afdd0ba283743f9f6146e57b31cfef159e00e178af8dR491 so having an explicit type here has no cost and offers an opportunity for a receiver to define backward compatibility func is needed
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
external_bool
branch
from
f7d7804 to
5920c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For legacy reason (i.e Docker Swarm)
externalat some point has been defined as a struct, then deprecated to get back to a plain boolean using parentnameto retrieve an existing resource.As we manage transformation in plain yaml we can now manage this legacy without having the go structs to reflect this weird heritage.
This PR changes
types.Externaldefinition to be a plain boolean, and handle name relocation during the "transform" phase.Also removes the weird assumption an
externalresource will have alwaysnameset, even this is just the same as the one defined by the mapping keys