Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a temporary job to sync v1 branch compose-spec.json with the spec repo one #495

Closed

Conversation

glours
Copy link
Collaborator

@glours glours commented Nov 21, 2023

We lost the PR creation for branch v1 when compose-spec.json diverge from the Compose spec

@glours glours requested a review from ndeloof as a code owner November 21, 2023 16:45
@glours glours requested a review from milas November 21, 2023 16:46
@ndeloof ndeloof force-pushed the main branch 3 times, most recently from 3718c19 to 402d2a3 Compare November 29, 2023 08:16
@ndeloof
Copy link
Collaborator

ndeloof commented Dec 21, 2023

as discussed with the team, would be better in practice we sync the other way, so that changes in compose-go includes both schema update + code then we update the compose-spec repo once approved

@glours
Copy link
Collaborator Author

glours commented Jan 12, 2024

Close, replace by compose-spec/compose-spec#455

@glours glours closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants