[ncurses] Add conan 2.0 compatibility #17805

samuel-emrys · 2023-06-03T02:27:48Z

This is a continuation of previous attempts to add conan 2 compatibility in #16780 and #15062

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

missing comma added

+ split method with too many local variables and too many statements + replace f-string without interpolated variables with normal string

CLAassistant · 2023-06-03T02:30:56Z

All committers have signed the CLA.

ghost · 2023-07-15T22:29:15Z

I detected other pull requests that are modifying ncurses/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

samuel-emrys · 2023-07-16T12:50:09Z

@madebr I resurrected this PR (originally authored in #16780) in the hope of resolving its issues and getting ncurses integrated for conan 2.0. It looks to already be in a really good state, but it's currently failing on shared MSVC builds (see the error in CI) - it's failing to build the terminfo database. There appears to be very little in the way of error messages or logs for me to latch onto here, so I'm having a hard time identifying what the problem actually is.

To make matters worse, I'm also having a hard time getting the 1.x variant to work, which would have helped me identify the difference between the two recipes to close the gap and hopefully resolve the issue.

I noticed that you were responsible for facilitating the upstreaming of the MSVC compatibility a few years ago in mirror/ncurses#1 - wondering if you're able to point me in the right direction here? Any ideas what might be breaking? Any help you can provide is appreciated.

madebr · 2023-07-16T16:17:09Z

Comparing the failed log with the output of these logs, the only difference I see is conan v2 adding DESTDIR=.. to make install.

conan-center-bot · 2023-08-11T18:37:36Z

Conan v1 pipeline ❌

Failure in build 3 (8e33b8d2c4bd854e6632a822716886a91a378f43):

ncurses/6.3@:
Didn't run or was cancelled before finishing

ncurses/6.4@:
CI failed to create some packages (All logs)

Logs for packageID d8750081d569e70303761db379eaccc3ef395e6e:

[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
[options]
ncurses:shared=True

[...]
/c/j2/w/prod-v1/buildsinglereference/s/48ae5e/1/bin/msys64/usr/bin/install -c -m 755 ../lib/formw6.dll /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/bin/formw6.dll
installing ../lib/formw.dll.lib as /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/lib/formw.dll.lib
/c/j2/w/prod-v1/buildsinglereference/s/48ae5e/1/bin/msys64/usr/bin/install -c -m 644 ../lib/formw.dll.lib /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/lib/formw.dll.lib
installing /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/form/form.h in /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/include
make[1]: Leaving directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/form'
( cd misc && make DESTDIR="/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e" RPATH_LIST="/lib" install )
make[1]: Entering directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc'
mkdir -p /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share
mkdir -p /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/tabset
DESTDIR=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e \
prefix=/ \
exec_prefix=/ \
bindir=/bin \
top_srcdir=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e \
srcdir=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc \
datadir=//share \
ticdir=//share/terminfo \
source=terminfo.tmp \
cross_compiling=no \
/bin/sh ./run_tic.sh
** Building terminfo database, please wait...
Running sh /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc/shlib tic to install /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/terminfo ...

	You may see messages regarding extended capabilities, e.g., AX.
	These are extended terminal capabilities which are compiled
	using
		tic -x
	If you have ncurses 4.2 applications, you should read the INSTALL
	document, and install the terminfo without the -x option.

ncurses 6.4.20221231
? tic could not build /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/terminfo
make[1]: Leaving directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc'
configure: WARNING: your environment uses the CC variable to hold CFLAGS/CPPFLAGS options
configure: WARNING: pkg-config is not installed
configure: WARNING: _POSIX_C_SOURCE definition is not usable
configure: WARNING: _XOPEN_SOURCE feature test macro appears to be predefined
configure: WARNING: cannot find regular expression library
configure: WARNING: no regular expression header found
mv: cannot stat 'conftest.o': No such file or directory
mv: cannot stat 'conftest.o': No such file or directory
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
make[1]: *** [Makefile:109: install.data] Error 1
make: *** [Makefile:139: install] Error 2
ncurses/6.4: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: ncurses/6.4: Error in package() method, line 262
	autotools.install()
	ConanException: Error 2 while executing make install DESTDIR=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e -j8

ncurses/6.2@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!

stale · 2023-09-17T15:40:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

samuel-emrys · 2023-09-18T00:47:19Z

bump

benny-edlund · 2023-10-18T23:18:34Z

Bump

ghost mentioned this pull request Jun 3, 2023

[service] Potentially conflicting recipes #3571

Closed

holger-detering added 8 commits June 3, 2023 12:00

ncurses: convert test_package to conan 2

2ffef15

ncurses: convert to conan 2.0

a28f018

ncurses: fix pylint complains

851d913

ncurses: add patch_description to patches

b1c524f

fixing shared library build

abfa602

missing comma added

set components names

a11e667

fix build for windows platform

09c7578

fix for pylint

8e33b8d

+ split method with too many local variables and too many statements + replace f-string without interpolated variables with normal string

samuel-emrys force-pushed the recipe/ncurses-conan2 branch from ac20eee to 8e33b8d Compare June 3, 2023 02:30

prince-chrismc mentioned this pull request Jun 3, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Jun 3, 2023

This comment has been minimized.

Sign in to view

samuel-emrys marked this pull request as draft July 4, 2023 10:51

ghost mentioned this pull request Jul 15, 2023

updates ncurses to conanv2 #18568

Closed

conan-center-bot added Service Under Maintenance and removed Failed labels Jul 24, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 11, 2023

samuel-emrys mentioned this pull request Sep 3, 2023

bump cpython dependencies #19547

Closed

3 tasks

stale bot added the stale label Sep 17, 2023

stale bot removed the stale label Sep 18, 2023

SpaceIm mentioned this pull request Sep 23, 2023

[package] ncurses/6.4: Seems to not be conan2 compatible #20084

Closed

ghost mentioned this pull request Oct 4, 2023

ncurses: migrate to Conan v2 #20355

Merged

samuel-emrys mentioned this pull request Oct 26, 2023

Cpython #20768

Closed

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Open

conan-center-bot closed this in #20355 Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ncurses] Add conan 2.0 compatibility #17805

[ncurses] Add conan 2.0 compatibility #17805

samuel-emrys commented Jun 3, 2023

CLAassistant commented Jun 3, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ghost commented Jul 15, 2023 •

edited by ghost

Loading

samuel-emrys commented Jul 16, 2023 •

edited

Loading

madebr commented Jul 16, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 11, 2023

stale bot commented Sep 17, 2023

samuel-emrys commented Sep 18, 2023

benny-edlund commented Oct 18, 2023

[ncurses] Add conan 2.0 compatibility #17805

[ncurses] Add conan 2.0 compatibility #17805

Conversation

samuel-emrys commented Jun 3, 2023

CLAassistant commented Jun 3, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

ghost commented Jul 15, 2023 • edited by ghost Loading

samuel-emrys commented Jul 16, 2023 • edited Loading

madebr commented Jul 16, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 11, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

stale bot commented Sep 17, 2023

samuel-emrys commented Sep 18, 2023

benny-edlund commented Oct 18, 2023

CLAassistant commented Jun 3, 2023 •

edited

Loading

ghost commented Jul 15, 2023 •

edited by ghost

Loading

samuel-emrys commented Jul 16, 2023 •

edited

Loading