Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickfast: migrate to Conan v2 #18674

Merged
merged 13 commits into from
Jun 28, 2024
Merged

quickfast: migrate to Conan v2 #18674

merged 13 commits into from
Jun 28, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023 •
edited
Loading

TODO

  • src/Application/DecoderConnection.cpp:361:43: error: invalid use of incomplete type 'class boost::asio::io_service'

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 10, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@valgur valgur force-pushed the migrate/quickfast branch from 8665ea9 to 879de85 Compare November 3, 2023 11:02
@valgur valgur marked this pull request as ready for review November 3, 2023 11:03
@stale stale bot removed the stale label Nov 3, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/quickfast branch from dd7bd1b to 64eda62 Compare January 20, 2024 13:58
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 7, 2024
@valgur valgur force-pushed the migrate/quickfast branch from 340ebf9 to d899ab6 Compare May 26, 2024 11:54
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 27, 2024
@uilianries uilianries self-assigned this Jun 27, 2024
@uilianries
Simplify test package
51066b1 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Improve msvc export define
f4c76b6 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Fix build on Windows
72c6384 
Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
update patch file
d7a3916 
Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Patch version 1.5
61b3a37 
Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 61b3a37
quickfast/1.5@#676e3c01a639c4800bb0fc0d960a282d 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libquickfast.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\quickfast.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
quickfast/cci.20170314@#346827d0e339e593c71ec9fe43e44872 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libquickfast.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\quickfast.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (61b3a377a508603733b0fe9993c5adf161151654):

  • quickfast/1.5:
    All packages built successfully! (All logs)

  • quickfast/cci.20170314:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (61b3a377a508603733b0fe9993c5adf161151654):

  • quickfast/cci.20170314:
    All packages built successfully! (All logs)

  • quickfast/1.5:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reduced test package
  • Update patch to fix Boost usage (Upstream is abandoned)
  • Bump to boost 1.85.0 (was 1.75.0)
  • Updated CMakeLists.txt to use targets generated by Conan

perseoGI
perseoGI approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c7af337 into conan-io:master Jun 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@perseoGI perseoGI perseoGI approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @uilianries @perseoGI