gm2calc: migrate to Conan v2 #18689
Merged
gm2calc: migrate to Conan v2 #18689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/gm2calc
branch
from
b94b1b1
to
a2e0386
Compare
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/gm2calc
branch
from
0cf2879
to
1673427
Compare
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/gm2calc
branch
from
1673427
to
016d04d
Compare
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 9 ( |
jwillikers
approved these changes
Nov 9, 2023
uilianries
approved these changes
Nov 10, 2023
|
|
||
| def generate(self): | ||
| tc = CMakeToolchain(self) | ||
| tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True |
There was a problem hiding this comment.
Suggested change
| tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True | |
| tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True | |
| tc.variables["ENABLE_TESTS"] = True |
Since 2.2 you can actually disable tests:
https://github.com/GM2Calc/GM2Calc/blob/v2.2.0/CMakeLists.txt#L9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
src/slhaea.h:25:10: fatal error: boost/algorithm/string/classification.hpp: No such file or directory.