-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jemalloc conan2 #18690
jemalloc conan2 #18690
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/jemalloc//'. 👋 @Hopobcn you might be interested. 😉 |
I detected other pull requests that are modifying jemalloc/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
If there's a way to distinguish if we are running in container vs native i would add additional check for forcing that vaddr setting |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…DEFINE`, fixing the autoreconf errors.
…is compiled by MSVC.
…nd use it to initialize `self.cpp_info.libs`.
…_DEFINE` for v5.3.0.
… value manually.
…/static` manually.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jabbas thanks a lot for your patience :)
I've reviewed the PR and it looks good. The only remaining issue is the current build fail, and I'd say this would then bee good to merge!
I've pushed 2 minor fixes to the recipe now that we're on it. I'm worried about the xmalloc thing. This seems to have been a typo of the original PR, as otherwise that option was not used. It seems to work locally for me, but I'd appreciate it if you could double check :)
Conan v1 pipeline ❌Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Ping. Are there any chances for this pr? |
Finally ported, closing this one, thanks a lot for your initial contribution! :) |
jemalloc/5.2.1
jemalloc/5.3.0
This is continuation of work of @0xFireWolf from that PR: #17722