Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libui: migrate to Conan v2 #18707

Closed
wants to merge 2 commits into from
Closed

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 20, 2023

Switched from gtk/3.x to gtk/system as the non-system version has not been migrated and also failed in v1 with PkgConfig not finding gtk+-3.0.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center and removed stale labels May 26, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 26, 2024
@conan-center-bot conan-center-bot removed stale Missing dependencies Build failed due missing dependencies in Conan Center labels Jul 15, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (3dbd3a352d537286cd7da62f71c52130b13ee4cb):

  • libui/0.4.1:
    CI failed to create some packages (All logs)

    Logs for packageID 295e626683678160d3dec526df76665f5873da0e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    libui:shared=False
    
    [...]
    libui/0.4.1: Preset 'release' added to CMakePresets.json. Invoke it manually using 'cmake --preset release'
    libui/0.4.1: If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/generators/conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Release'
    libui/0.4.1: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    libui/0.4.1: Calling build()
    libui/0.4.1: CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/package/295e626683678160d3dec526df76665f5873da0e" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/src"
    
    ----Running------
    > cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/package/295e626683678160d3dec526df76665f5873da0e" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/src"
    -----------------
    -- Using Conan toolchain: /home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/generators/conan_toolchain.cmake
    -- Conan toolchain: Setting CMAKE_POSITION_INDEPENDENT_CODE=ON (options.fPIC)
    -- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
    -- The C compiler identification is GNU 5.4.0
    -- The CXX compiler identification is GNU 5.4.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/gcc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/g++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") 
    -- Checking for module 'gtk+-3.0'
    --   No package 'gtk+-3.0' found
    -- Configuring incomplete, errors occurred!
    See also "/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/CMakeFiles/CMakeOutput.log".
    libui/0.4.1: 
    dpkg-query: no packages found matching libgtk2.0-dev
    debconf: delaying package configuration, since apt-utils is not installed
    CMake Error at /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:545 (message):
      A required package was not found
    Call Stack (most recent call first):
      /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:733 (_pkg_check_modules_internal)
      unix/CMakeLists.txt:4 (pkg_check_modules)
    
    
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    libui/0.4.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libui/0.4.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libui/0.4.1: ERROR: Package '295e626683678160d3dec526df76665f5873da0e' build failed
    libui/0.4.1: WARN: Build folder /home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release
    ERROR: libui/0.4.1: Error in build() method, line 58
    	cmake.configure()
    	ConanException: Error 1 while executing cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/package/295e626683678160d3dec526df76665f5873da0e" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/70010/faaab/.conan/data/libui/0.4.1/_/_/build/295e626683678160d3dec526df76665f5873da0e/src"
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (3dbd3a352d537286cd7da62f71c52130b13ee4cb):

  • libui/0.4.1:
    CI failed to create some packages (All logs)

    Logs for packageID 799145e8e02a4a9b39e90b11dc5e2f5fc1dfa1b2:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    libui/0.4.1: Generators folder: /home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/build/Release/generators
    libui/0.4.1: CMakeToolchain generated: conan_toolchain.cmake
    libui/0.4.1: CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/build/Release/generators/CMakePresets.json
    libui/0.4.1: CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/src/CMakeUserPresets.json
    libui/0.4.1: CMakeDeps necessary find_package() and targets for your CMakeLists.txt
        find_package(gtk)
        target_link_libraries(... gtk::gtk)
    libui/0.4.1: Generating aggregated env files
    libui/0.4.1: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
    libui/0.4.1: Calling build()
    libui/0.4.1: Running CMake.configure()
    libui/0.4.1: RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/p" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/src"
    -- Using Conan toolchain: /home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/build/Release/generators/conan_toolchain.cmake
    -- Conan toolchain: Setting CMAKE_POSITION_INDEPENDENT_CODE=ON (options.fPIC)
    -- Conan toolchain: Defining architecture flag: -m64
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
    -- The C compiler identification is GNU 11.4.0
    -- The CXX compiler identification is GNU 11.4.0
    -- Check for working C compiler: /usr/local/bin/cc
    -- Check for working C compiler: /usr/local/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/local/bin/c++
    -- Check for working CXX compiler: /usr/local/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") 
    -- Checking for module 'gtk+-3.0'
    --   No package 'gtk+-3.0' found
    CMake Error at /usr/share/cmake-3.15/Modules/FindPkgConfig.cmake:458 (message):
      A required package was not found
    Call Stack (most recent call first):
      /usr/share/cmake-3.15/Modules/FindPkgConfig.cmake:637 (_pkg_check_modules_internal)
      unix/CMakeLists.txt:4 (pkg_check_modules)
    
    
    -- Configuring incomplete, errors occurred!
    See also "/home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/build/Release/CMakeFiles/CMakeOutput.log".
    
    libui/0.4.1: ERROR: 
    Package '799145e8e02a4a9b39e90b11dc5e2f5fc1dfa1b2' build failed
    libui/0.4.1: WARN: Build folder /home/conan/workspace/prod-v2/bsr/63179/bdcca/p/b/libui38fdfefa14774/b/build/Release
    ERROR: libui/0.4.1: Error in build() method, line 58
    	cmake.configure()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 15, 2024
@valgur
Copy link
Contributor Author

valgur commented Sep 9, 2024

Don't close.

@github-actions github-actions bot removed the stale label Sep 10, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 10, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants