Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsolace: migrate to Conan v2 #18722

Merged
merged 3 commits into from
Nov 8, 2023
Merged

libsolace: migrate to Conan v2 #18722

merged 3 commits into from
Nov 8, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 20, 2023 •
edited
Loading

TODO

  • undefined reference to Solace::getBuildVersion() in test_package
  • 'fPIC' option not managed correctly

@prince-chrismc prince-chrismc mentioned this pull request Jul 20, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 10, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (a4258aecc0a0a9667eee5bff8cacea1bdede542d):

  • libsolace/0.4.1:
    All packages built successfully! (All logs)

  • libsolace/0.3.9:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (a4258aecc0a0a9667eee5bff8cacea1bdede542d):

  • libsolace/0.4.1:
    All packages built successfully! (All logs)

  • libsolace/0.3.9:
    All packages built successfully! (All logs)

@valgur valgur mentioned this pull request Nov 8, 2023
Open
uilianries
uilianries approved these changes Nov 8, 2023
View reviewed changes
recipes/libsolace/all/conanfile.py
Comment on lines +77 to +80
def _patch_sources(self):
replace_in_file(self, os.path.join(self.source_folder, "CMakeLists.txt"),
"include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)\nconan_basic_setup()",
"")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. It deserves an extra contribution to the upstream. I'll do it later.

@uilianries uilianries self-assigned this Nov 8, 2023
@uilianries
Copy link
Member

I created a PR to the upstream, so we will not need to update the recipe again, in case a new release be available: abbyssoul/libsolace#9

@conan-center-bot conan-center-bot merged commit e4f216c into conan-io:master Nov 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @uilianries @jwillikers