-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dd-opentracing-cpp: migrate to Conan v2 #18816
dd-opentracing-cpp: migrate to Conan v2 #18816
Conversation
I detected other pull requests that are modifying dd-opentracing-cpp/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fe43394
to
39bd6c9
Compare
The last grpc issue lost some PR jobs, I've retriggered them now |
|
||
def generate(self): | ||
tc = CMakeToolchain(self) | ||
if self.settings.compiler == "clang" and Version(self.settings.compiler.version) < "4.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still miss information, I see no relation in the upstream. Please, remove it.
recipes/dd-opentracing-cpp/all/patches/1.3.0/0001-Find-packages-setup.patch
Outdated
Show resolved
Hide resolved
recipes/dd-opentracing-cpp/all/patches/1.3.0/0001-Find-packages-setup.patch
Outdated
Show resolved
Hide resolved
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
91c546f
to
ed5c222
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ed5c222dd-opentracing-cpp/1.3.7@#af1b83338d57a09bc96c7e70fcc28d3b
dd-opentracing-cpp/1.3.0@#eaa46748bda8d8f956117963536d6043
|
Can this be merged? Or what is missing? I was about to write my own v2 recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved some files around as a last minor change, looks great now, thanks a lot for your patience :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 ( |
Hooks produced the following warnings for commit aa2637edd-opentracing-cpp/1.3.7@#8dbf0f18cc621a7735f25e6fc987ff15
dd-opentracing-cpp/1.3.0@#8f7988e1b8e4fd1f8c8de50a1166c2f3
|
No description provided.