Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairomm: migrate to Conan v2 #18884

Merged
merged 4 commits into from
Nov 17, 2023
Merged

cairomm: migrate to Conan v2 #18884

merged 4 commits into from
Nov 17, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023

No description provided.

@ghost ghost mentioned this pull request Jul 24, 2023
Closed
@ghost
Copy link

ghost commented Jul 24, 2023

I detected other pull requests that are modifying cairomm/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@prince-chrismc prince-chrismc mentioned this pull request Jul 24, 2023
Open
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 20, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Sep 17, 2023
Closed
3 tasks
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (fab86616df216b8420ed3e3c7144c02ba6ae720e):

  • cairomm/1.18.0:
    All packages built successfully! (All logs)

  • cairomm/1.16.2:
    All packages built successfully! (All logs)

  • cairomm/1.17.1:
    All packages built successfully! (All logs)

  • cairomm/1.14.5:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (fab86616df216b8420ed3e3c7144c02ba6ae720e):

  • cairomm/1.18.0:
    All packages built successfully! (All logs)

  • cairomm/1.17.1:
    All packages built successfully! (All logs)

  • cairomm/1.16.2:
    All packages built successfully! (All logs)

  • cairomm/1.14.5:
    All packages built successfully! (All logs)

@valgur valgur mentioned this pull request Nov 8, 2023
Open
AbrilRBS
AbrilRBS approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot! :)

recipes/cairomm/all/conanfile.py
def _source_subfolder(self):
return "source_subfolder"
def _abi_version(self):
return "1.16" if Version(self.version) >= "1.16.0" else "1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not introduce too much variation complexity, so I'm ok with keeping the old version around for a bit longer, thanks for doing the extra work to keep its support when it would have been easier to just don't support 1.14 :)

@AbrilRBS AbrilRBS self-assigned this Nov 16, 2023
@conan-center-bot conan-center-bot merged commit e53df23 into conan-io:master Nov 17, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers