Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpir: migrate to Conan v2 #18903

Merged
merged 15 commits into from
Apr 8, 2024
Merged

mpir: migrate to Conan v2 #18903

merged 15 commits into from
Apr 8, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 25, 2023 •
edited
Loading

.

@prince-chrismc prince-chrismc mentioned this pull request Jul 25, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 9, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur force-pushed the migrate/mpir branch 2 times, most recently from 19b668d to 7f2ff3d Compare October 25, 2023 07:52
@stale stale bot removed the stale label Nov 1, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
memsharded
memsharded reviewed Nov 7, 2023
View reviewed changes
recipes/mpir/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mpir/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
1 similar comment
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@Ahajha
Copy link
Contributor

Ahajha commented Dec 31, 2023

I added self.tool_requires("libtool/2.4.7"), that fixed Linux at least for me.

@conan-center-bot

This comment has been minimized.

Sign in to view
@Ahajha
Copy link
Contributor

Ahajha commented Jan 1, 2024

I pushed the fixes for apple-clang to my branch here: https://github.com/Ahajha/conan-center-index/tree/migrate/mpir

Essentially, two things:

  1. Some missing commas between some argument strings
  2. Backport of an XCode 12+ configure fix

@valgur
Merge remote-tracking branch 'ahajha/migrate/mpir' into migrate/mpir
ff0be92 
# Conflicts:
#	recipes/mpir/all/conanfile.py
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 15 (81b98c7c215ea23d1d60126255a19f9ad9aa1630):

  • mpir/3.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (81b98c7c215ea23d1d60126255a19f9ad9aa1630):

  • mpir/3.0.0:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Hooks produced the following warnings for commit 81b98c7
mpir/3.0.0@#3d95ef96fba920b00d01f19c221055b5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libmpirxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmpxx.so' links to system library 'm' but it is not in cpp_info.system_libs.

@valgur
Copy link
Contributor Author

valgur commented Jan 1, 2024

Thanks a lot, @Ahajha! 🎉

@cen1
Copy link

cen1 commented Feb 16, 2024

Any way to help push this over the line? GMP is broken on Windows and MPIR is the only alternative but stuck in conan v1. This essentially blocks me upgrading to conan v2 which is incredibly annoying.

@valgur
Copy link
Contributor Author

valgur commented Apr 5, 2024

@RubenRBS @jcar87 Friendly ping for a review. This package is a dependency for a few other GNU projects on CCI.

@AbrilRBS AbrilRBS self-assigned this Apr 5, 2024
uilianries
uilianries reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for Rubén's final review.

recipes/mpir/all/conandata.yml
@@ -1,4 +1,10 @@
sources:
"3.0.0":
url: "http://mpir.org/mpir-3.0.0.zip"
sha256: "6277d3cc36ff39c98e4d4cc17b46b5a6ff42a22d30a4130b2d49255f98dd8c1f"
url: "https://github.com/wbhart/mpir/archive/refs/tags/mpir-3.0.0.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author commented about the website change here wbhart/mpir#298

recipes/mpir/all/patches/fix_xcode_12_configure.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches with wbhart/mpir@bbc43ca 👍

AbrilRBS
AbrilRBS approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@conan-center-bot conan-center-bot merged commit 3849e17 into conan-io:master Apr 8, 2024
13 checks passed
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
@valgur @memsharded
(conan-io#18903) mpir: migrate to Conan v2
92d9cf3 
* mpir: migrate to Conan v2

* mpir: fix apple-clang issue

* mpir: get rid of vs_ide_version() use

* Update recipes/mpir/all/conanfile.py

* Update recipes/mpir/all/conanfile.py

* mpir: fix apple arch detection

* mpir: remove unused import

* mpir: add libtool build dependency

* Add missing commas

* Backport XCode 12+ configure fix

* mpir: fix to_apple_arch()

---------

Co-authored-by: James <[email protected]>
Co-authored-by: Alex Trotta <[email protected]>
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
@valgur @memsharded @ericLemanissier
(conan-io#18903) mpir: migrate to Conan v2
8cb21b7 
* mpir: migrate to Conan v2

* mpir: fix apple-clang issue

* mpir: get rid of vs_ide_version() use

* Update recipes/mpir/all/conanfile.py

* Update recipes/mpir/all/conanfile.py

* mpir: fix apple arch detection

* mpir: remove unused import

* mpir: add libtool build dependency

* Add missing commas

* Backport XCode 12+ configure fix

* mpir: fix to_apple_arch()

---------

Co-authored-by: James <[email protected]>
Co-authored-by: Alex Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@uilianries uilianries uilianries left review comments

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@valgur @conan-center-bot @Ahajha @cen1 @uilianries @AbrilRBS @memsharded @jwillikers