libvault: fix import of Version + decrease min Visual Studio Version + many small fixes

[SpaceIm]

• fix import of Version (from conan import Version was illegal and breaks in conan 2.0.10)
• use export_conandata_patches()
• remove useless VirtualBuildEnv generator (there is no build requirements in this recipe
• bump libcurl
• remove useless catch2 in requirements (it's used for tests, but tests are disabled...)
• add package_type
• fix min Visual Studio (it was ... 19, which doesn't make sense) and add min version for msvc
• use self.settings instead of self.info.settings in validate()
• remove useless CMakeLists wrapper (it had old conan v1 stuff with conan_basic_setup() and was not used at all...)
• add a layout
• add libm to system libs on Linux & FreeBSD only

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[SpaceIm]

Last PR of libvault is #14498, far before v2 pipeline. There might be more fixes needed to pass this pipeline.

[SpaceIm]

libvault shared, msvc:

ERROR: libvault/0.52.0 (test package): Error in test() method, line 19
	self.run(bin_path, run_environment=True)
	ConanException: Error 3221225785 while executing bin\test_package

Ok so the problem on Windows is that there is a Vault.dll system library in System32 (found first by runtime loader), and libvault creates vault.dll file, it's an unfortunate name.

[SpaceIm]

libvault shared, msvc:

ERROR: libvault/0.52.0 (test package): Error in test() method, line 19
	self.run(bin_path, run_environment=True)
	ConanException: Error 3221225785 while executing bin\test_package

Ok so the problem on Windows is that there is a Vault.dll system library in System32 (found first by runtime loader), and libvault creates vault.dll file, it's an unfortunate name.

abedra/libvault#116

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 8 (316651ca1f788e24dafaf71a18ed62b653bf93c3):

• libvault/0.51.0:
  All packages built successfully! (All logs)

• libvault/0.48.0:
  All packages built successfully! (All logs)

• libvault/0.52.0:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (316651ca1f788e24dafaf71a18ed62b653bf93c3):

• libvault/0.48.0:
  All packages built successfully! (All logs)

• libvault/0.52.0:
  All packages built successfully! (All logs)

• libvault/0.51.0:
  All packages built successfully! (All logs)

[AbrilRBS]

Thanks! One question about one of the lines of the CMake patch, otherwise looks nice

Thanks a lot as well for the detailed PR message, helps a lot :)

[SpaceIm]

Is there still anything preventing this PR to be accepted and merged?

[SpaceIm]

@RubenRBS @uilianries could you review this one please?

[ghost]

I detected other pull requests that are modifying libvault/all recipe:

• fixed libvault recipe for 2.0 #21962
• libvault: add 0.59.0 #21340

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[SpaceIm]

@RubenRBS @uilianries could you accept this PR please? It's been 3 months :(

[uilianries]

LGTM