Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style fixes/tweaks for npm library #355

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: style fixes/tweaks for npm library #355

merged 1 commit into from
Feb 7, 2024

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Feb 7, 2024

  • add missing px to inadvertently dimensionless values
  • specify line-height normal for modal-button so it doesn't default to something else in CODAP v3
  • bump version to 2.0.0-pre.2

@kswenson kswenson requested a review from dougmartin February 7, 2024 06:19
dougmartin
dougmartin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kswenson kswenson merged commit 42eecfe into master Feb 7, 2024
2 checks passed
@kswenson kswenson deleted the 186987479-style-tweaks branch February 7, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougmartin dougmartin dougmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kswenson @dougmartin