fix: export CFM version number rather than __PACKAGE_VERSION__
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswenson
force-pushed
the
export-lib-version
branch
2 times, most recently
from
9285471 to
a577ac6
Compare
kswenson
changed the title
__PACKAGE_VERSION__
kswenson
force-pushed
the
export-lib-version
branch
from
a577ac6 to
0979aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFM code contains the string
__PACKAGE_VERSION__in several places. The expectation is that this string will be replaced by the actual CFM version number frompackage.jsonat build time. For the webpack build, this is handled by theReplaceInFileWebpackPlugin. For the library export we don't have a bundler that can handle the string replacement. Therefore, this PR introduces thebuild-library.shbash script which builds the exported library folders with calls totsc, as before, then also usesgrepandsedto perform the string replacement of the version number. The script was developed with the help of ChatGPT.