use puppeteer fullPage option to support dynamic height #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/188381057
Support dynamic heights for the screenshot images.
This uses puppeteer's
fullPage
option.Additionally it:
"use strict;"
header to each javascript file.This code has been deployed to the staging site. The basic features can be checked with the shutterbug client demo site.
https://concord-consortium.github.io/shutterbug.js/demo/
On each demo page you have to add
?shutterbugUrl=https://api.concord.org/shutterbug-staging
so it uses the staging site. For example:https://concord-consortium.github.io/shutterbug.js/demo/dynamic-css-example.html?shutterbugUrl=https://api.concord.org/shutterbug-staging
There isn't example on that demo site that uses the new fullPage option. However can be tested by snapshotting some pages:
Without
fullPage
:curl --data '{"url":"https://concord.org/about/our-impact/","width":1000,"height":800}' https://api.concord.org/shutterbug-staging
With
fullPage
:curl --data '{"url":"https://concord.org/about/our-impact/","width":1000,"height":800,"fullPage":true}' https://api.concord.org/shutterbug-staging