Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use instance vars to compute hash for unique intervals #58

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

aoldershaw
Copy link
Contributor

#54 ensured even distribution for a given interval per pipeline based on team name + pipeline name, but this doesn't work for pipeline instances since they have the same team + pipeline name

since all instance pipelines in a single group have the same
team/pipeline name, we need something else for their uniqueness

Signed-off-by: Aidan Oldershaw <[email protected]>
Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoldershaw aoldershaw merged commit 9e13208 into master Jan 11, 2021
@aoldershaw aoldershaw deleted the unique-pipeline-instances branch January 11, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants