Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use noarch python {{ python_min }} variable #5

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 11, 2024

  • Use 'python {{ python_min }}' syntax for the python requirements for noarch python recipes.
  • Add recipe/conda_build_config.yaml to override the global python_min with cabinetry's python_min of 3.8.
  • Add conda-forge/scikit-hep as feedstock maintainers.
  • Build with '--no-deps --no-build-isolation' to verify build requirements are specified.
  • Add setuptools build backend as host requirement.
  • Use 'pypi.org'.
  • Bump build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Use 'python {{ python_min }}' syntax for the python requirements for noarch
  python recipes.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
* Add recipe/conda_build_config.yaml to override the global python_min with
  cabinetry's python_min of 3.8.
* Add conda-forge/scikit-hep as feedstock maintainers.
* Build with '--no-deps --no-build-isolation' to verify build requirements are
  specified.
* Add setuptools as build requirements.
* Use 'pypi.org'.
* Bump build number.
@matthewfeickert matthewfeickert self-assigned this Nov 11, 2024
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package cabinetry using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

conda-forge-webservices[bot] and others added 2 commits November 11, 2024 23:43
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11787976158.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 11, 2024 23:52
@matthewfeickert matthewfeickert merged commit 8688d47 into conda-forge:main Nov 11, 2024
5 checks passed
@matthewfeickert matthewfeickert deleted the mnt/lower-bound-min-python branch November 11, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants