Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Announcements section. #1650

Closed
wants to merge 3 commits into from
Closed

Restructure Announcements section. #1650

wants to merge 3 commits into from

Conversation

ssurbhi560
Copy link
Contributor

fixes #1611

In this PR changes have been made as mentioned here. Please give more suggestions or ideas that should be included to make it better. These are a few questions that I'd like to ask:

  1. What should be the format of the dates in the announcements?
  2. Should we mention year even in the specific announcement as well? [I have not added it as of now, as it looked quite obvious, that if the announcement is under a particular year, then the date belongs to that year only]

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords

@ssurbhi560 ssurbhi560 requested a review from a team as a code owner March 27, 2022 23:05
@ssurbhi560
Copy link
Contributor Author

Please review these changes @beckermr! :)

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will break our RSS feeds so we cannot merge them.

@ssurbhi560
Copy link
Contributor Author

I did not notice that @beckermr, is there any way to resolve this?

@beckermr
Copy link
Member

Double check the rss after you build locally and see what happens in our custom newsfeed package.

@ssurbhi560
Copy link
Contributor Author

Thanks @beckermr for letting me know, I will check it and try to resolve this soon.

@ssurbhi560 ssurbhi560 closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Better anchoring of announcements
2 participants