Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extra section-recipe maintainer and feedstock-name #1772

Merged
merged 3 commits into from
Jun 14, 2022
Merged

add extra section-recipe maintainer and feedstock-name #1772

merged 3 commits into from
Jun 14, 2022

Conversation

ssurbhi560
Copy link
Contributor

Closes #1769 and #1331

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@ssurbhi560 ssurbhi560 requested a review from a team as a code owner June 10, 2022 12:03
kathatherine
kathatherine suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing! Otherwise, it looks great

src/maintainer/adding_pkgs.rst Outdated Show resolved Hide resolved
kathatherine
kathatherine approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kathatherine
Copy link
Contributor

@beckermr You good with merging this?

@beckermr beckermr merged commit 9d7acef into conda-forge:main Jun 14, 2022
@jakirkham
Copy link
Member

This is great! Thank you 🙏

@ssurbhi560 ssurbhi560 deleted the add-extra-section-in-recipe-meta.yaml-section branch June 15, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathatherine kathatherine kathatherine approved these changes

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document extras feedstock-name
4 participants
@ssurbhi560 @kathatherine @jakirkham @beckermr