MNT: Default to '--no-deps --no-build-isolation' for Python build scripts #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipts * Add --no-deps --no-build-isolation to pip installs for scripts to ensure that all build-system dependencies are included as host requirements. * Add news entry for update.
matthewfeickert
force-pushed
the
feat/use-no-deps-no-build-isolation-python
branch
from
5851c3f to
67f7003
Compare
|
@conda-forge/core this is ready for review. Apologies in advance if I've missed any reasons on why this isn't used already. |
Possibly @henryiii's point in https://github.com/conda-forge/packaging-feedstock/pull/32/files#r1844918884. |
|
Putting this into draft until there's an answer on conda/grayskull#582. |
|
Closing given conda/grayskull#582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2136
--no-deps --no-build-isolationto pip installs for scripts to ensure that allbuild-systemdependencies are included ashostrequirements.Checklist
newsentrypython conda_smithy/schema.py)