Add optional, constrained dependencies #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users want to install `dask-core` with `numpy` (or similar), make sure that the `numpy` version they install matches the version constraints Dask would add to these constraints. xref: https://github.com/dask/dask/blob/499f4055da707fa76d06a2b79f408f124eee4723/pyproject.toml#L48-L77
Rebuild now that option, constrained dependencies are included.
jakirkham
requested review from
charlesbluca,
jcrist,
jrbourbeau,
martindurant,
mrocklin,
pitrou,
shoyer,
sinhrks and
TomAugspurger
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
commented
Jun 15, 2023
| run_constrained: | ||
| - numpy >=1.21 | ||
| - pandas >=1.3 | ||
| - bokeh >=2.4.2 |
There was a problem hiding this comment.
Should this constraint be aligned with the dask package? If so, should this also be updated upstream?
Suggested change
| - bokeh >=2.4.2 | |
| - bokeh >=2.4.2,!=3.0.* |
5 tasks
jakirkham
commented
Jun 15, 2023
| @@ -33,6 +32,13 @@ requirements: | |||
| - pyyaml >=5.3.1 | |||
| - toolz >=0.10.0 | |||
| - importlib_metadata >=4.13.0 | |||
| run_constrained: | |||
There was a problem hiding this comment.
Should this constraint be added (like in the dask package)? If so, should this also be updated upstream?
Suggested change
| run_constrained: | |
| run_constrained: | |
| - cytoolz >=0.11.0 |
|
Even though upstream has
|
|
Side note: As part of this work, noticed a simplification that could be made upstream ( dask/dask#10357 ) |
|
@jrbourbeau what don't you think of this proposal? |
This was referenced Jul 7, 2023
Merged
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users want to install
dask-corewithnumpy(or similar), make sure that thenumpyversion they install matches the version constraints Dask would add to these constraints.xref: https://github.com/dask/dask/blob/499f4055da707fa76d06a2b79f408f124eee4723/pyproject.toml#L48-L77
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)