Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marvin to the README #8

Merged

Conversation

GenevieveBuckley
Copy link
Contributor

@GenevieveBuckley GenevieveBuckley commented Mar 2, 2021

Marvin is our newest project maintainer, this PR adds his name to the conda-forge feedstock README page.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@jakirkham
Copy link
Member

Thanks Genevieve! 😄

If we add him to this list (see below) and re-render (asking the bot will do that), that should take care of all the other things in the feedstock that need to be updated

extra:
recipe-maintainers:
- GenevieveBuckley
- jakirkham

@jakirkham
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@GenevieveBuckley
Copy link
Contributor Author

@jakirkham I can't figure out where in the settings to invite @m-albert to the dask-image team on conda-forge. Do you remember this from last time? (Not much point adding his name to the files here if he can't merge anything)

@jakirkham
Copy link
Member

We might want to bump the build number as well given the requirement change. Though think we should be good after that change. Thanks again for handling this Genevieve! 😄

@jakirkham
Copy link
Member

@jakirkham I can't figure out where in the settings to invite @m-albert to the dask-image team on conda-forge. Do you remember this from last time? (Not much point adding his name to the files here if he can't merge anything)

Yeah when we merge this PR the bot will add anyone in that recipe list to the team maintaining this feedstock

John suggests I should bump the build number given I've just changed the requirements to add a lower bound to the acceptable versions of python. We need to reset this number back to zero when the next release comes out.
@GenevieveBuckley
Copy link
Contributor Author

@jakirkham I can't figure out where in the settings to invite @m-albert to the dask-image team on conda-forge. Do you remember this from last time? (Not much point adding his name to the files here if he can't merge anything)

Yeah when we merge this PR the bot will add anyone in that recipe list to the team maintaining this feedstock

Oooooh, ok then!

This process is very opaque and confusing to me. Glad we're getting there slowly.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Mar 2, 2021
@github-actions github-actions bot merged commit 9b63e51 into conda-forge:master Mar 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@GenevieveBuckley
Copy link
Contributor Author

🎉

@GenevieveBuckley GenevieveBuckley deleted the add-marvin-to-readme branch March 2, 2021 01:31
@jakirkham
Copy link
Member

Yeah when we merge this PR the bot will add anyone in that recipe list to the team maintaining this feedstock

Oooooh, ok then!

This process is very opaque and confusing to me. Glad we're getting there slowly.

Yeah any advice on how we can make this clearer would be welcome.

FWIW we have this on the webpage and a doc section here.

@jakirkham
Copy link
Member

Should add details about the invite are included in this comment ( 9b63e51#commitcomment-47718198 )

@jakirkham
Copy link
Member

Probably the confusion is on me for not pointing out those resources earlier

@GenevieveBuckley
Copy link
Contributor Author

I think I found those docs earlier, but it was an overwhelming amount of information and I couldn't work out what was relevant to me.

@jakirkham
Copy link
Member

Gotcha. How could we make it better to sift through? Smaller pages? Finer grained TOC? Something else?

@GenevieveBuckley
Copy link
Contributor Author

Gotcha. How could we make it better to sift through? Smaller pages? Finer grained TOC? Something else?

There's no high-level overview of what the overall process is, so I had no structure to fit any of that information into. That's the biggest thing that would help. There's no clear story for "this is how you move through a conda-forge process".

It was also hard to work out what was relevant to me, as a new maintainer to a project that already had a conda-forge feedstock set up. A lot of the getting started as a maintainer docs are about setting up a feedstock from scratch, which is great but not what I needed. I didn't want to spend ages reading through everything, I wanted to finish making the release!

It turns out that you don't actually need to know/understand very much to release new versions if the feedstock is already set up. But it would be much better if I did understand it better, because even the checklist of stuff that the conda-forge bot gives you to do before merging the PR is difficult to if you've never done it before. Even now I think I still get warnings and just ...ignore them, because I don't know how to fix it & the release was ok last time.

I also didn't have a good sense of what actions are handled automatically when PRs are merged here (eg: the new release is made available on conda-forge, a new person is automatically added to the maintainer team here). I think these are all symptoms of not understanding the overall process involved.

I understood packaging with pip before this but had zero clue about how conda packaging worked. I once asked in a tutorial, and was told "that's too complicated". I can see why they said that now :)

@jakirkham
Copy link
Member

Great, thank you for writing that up 😄

Have filed an issue very briefly summarizing the need with a link to this comment for more details

@m-albert
Copy link
Contributor

m-albert commented Mar 4, 2021

Thanks for adding me and documenting things in this PR, which might be useful in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants