Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.10.0 #294

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Release 2024.10.0 #294

merged 5 commits into from
Oct 17, 2024

Conversation

pentschev
Copy link
Contributor

@pentschev pentschev commented Oct 17, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@pentschev
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package distributed using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@pentschev pentschev mentioned this pull request Oct 17, 2024
4 tasks
@charlesbluca
Copy link
Member

Think we'll need to do something like dask/distributed#8890 here to address the sunsetting of implicit pip build deps

@pentschev
Copy link
Contributor Author

Just noticed that as well, for now I've simply added setuptools without a pin, like in the dask-core recipe.

@pentschev
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@charlesbluca
Copy link
Member

Think that should do it, though was going to comment on the dask-core feedstock release saying for posterity it might make sense using setuptools >=62.6 since this is the pinning specified in each project's pyproject.toml

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11392419660.

@pentschev
Copy link
Contributor Author

Ok, no need to wait here then, pinned added in 1a262ce .

@pentschev
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11392486407.

Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev! Tried generating the recipe with grayskull pypi distributed just to make sure we weren't missing any other dependency changes, this looks good

@charlesbluca charlesbluca merged commit fa9ca38 into conda-forge:main Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants