Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shared library on Unix #15

Merged
merged 4 commits into from
Nov 8, 2020
Merged

Adding shared library on Unix #15

merged 4 commits into from
Nov 8, 2020

Conversation

tdegeus
Copy link
Member

@tdegeus tdegeus commented Nov 6, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #10

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tdegeus
Copy link
Member Author

tdegeus commented Nov 6, 2020

@conda-forge-admin, please rerender

@tdegeus tdegeus changed the title Adding shared library on Unix [WIP] Adding shared library on Unix Nov 6, 2020
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tdegeus
Copy link
Member Author

tdegeus commented Nov 6, 2020

@leouieda @ocefpaf Working on two things here : the installation of the shared library as requested in #10 and the permission issues in #11 . Note that the permission issues are now reproduced even in the feedstock (don't know how to solve yet though)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [27, 28]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
@tdegeus tdegeus changed the title [WIP] Adding shared library on Unix Adding shared library on Unix Nov 6, 2020
@tdegeus
Copy link
Member Author

tdegeus commented Nov 6, 2020

Ready for review @leouieda @ocefpaf

Note: ghostscript contains the 'mistake' that it name libgs.dylib.9.53.3 whereas the convention on osx is libgs.9.53.3.dylib, but I don't think it is the feedstock that should address this issue.

@tdegeus
Copy link
Member Author

tdegeus commented Nov 7, 2020

P.S. I really only modified meta.yaml and build.sh, the rest comes from conda. I just squashed at some point so that's why it might appeared as if I modified these files.

@@ -3,5 +3,12 @@
./configure --prefix=${PREFIX}

make -j${CPU_COUNT}
make so -j${CPU_COUNT}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it so ;-p, sorry, I could not resist.

@ocefpaf ocefpaf merged commit 1dc727b into conda-forge:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request that libgs.so or libgs.dylib (MacOS) be delivered in conda-forge Ghostscript
4 participants